Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-1251] bookable timeslots calculated wrong #7687

Closed
AUT-TOM opened this issue Mar 13, 2023 · 10 comments · Fixed by #7792 or #9802
Closed

[CAL-1251] bookable timeslots calculated wrong #7687

AUT-TOM opened this issue Mar 13, 2023 · 10 comments · Fixed by #7792 or #9802
Assignees
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working High priority Created by Linear-GitHub Sync
Milestone

Comments

@AUT-TOM
Copy link

AUT-TOM commented Mar 13, 2023

I have two event types, one is correct and the second one does not count my availability correct.

My availability times are:

2023-03-13 11_22_07-Ninja Warrior Einzeltraining _ Termintyp _ Cal com – Mozilla Firefox

so until 8pm with an 90 minutes event

2023-03-13 11_24_29-Ninja Warrior Einzeltraining _ Parkour Austria _ Cal com – Mozilla Firefox

But the system calculates my last bookable time at 5:30pm => it should be 6:30pm

I've also double and triple checked my time limits and browser cache.
I've also created a whole new availability "work time" but it still does not calculate it correctly, but only for my second event type.. the first one calculates correct.

CAL-1251

@maige-app maige-app bot added 🐛 bug Something isn't working Medium priority Created by Linear-GitHub Sync labels Mar 13, 2023
@Udit-takkar
Copy link
Contributor

@AUT-TOM can you share your booking url for this event type?

@AUT-TOM
Copy link
Author

AUT-TOM commented Mar 13, 2023

@Udit-takkar Udit-takkar added the linear Sync Github Issue from community members to Linear.app label Mar 14, 2023
@Udit-takkar Udit-takkar changed the title bookable timeslots calculated wrong [CAL-1251] bookable timeslots calculated wrong Mar 14, 2023
@AUT-TOM
Copy link
Author

AUT-TOM commented Mar 15, 2023

@Udit-takkar

U need any more information to look into that problem?
I have no idea where to start looking, but what I can see is that this date calculates wrong https://cal.com/pkaustria/ninja-warrior-einzeltraining?duration=90&date=2023-03-24 and this calculates right https://cal.com/pkaustria/ninja-warrior-einzeltraining?duration=90&date=2023-03-26 altough those days should have the same time slots until 6:30pm

this issue is a show-stopper for me, I hope you can fix this asap

@Udit-takkar
Copy link
Contributor

Udit-takkar commented Mar 15, 2023

@AUT-TOM thanks for reaching out. We are investigating this bug. Maybe the cause of this bug is DST

@PeerRich PeerRich added High priority Created by Linear-GitHub Sync and removed Medium priority Created by Linear-GitHub Sync labels Mar 16, 2023
@AUT-TOM
Copy link
Author

AUT-TOM commented Mar 21, 2023

@Udit-takkar
should the problem be fixed? Because the bug is closed/merged into production, but it's still not working on my side

https://cal.com/pkaustria/parkour-einzeltraining?duration=90&date=2023-03-25 (18:00) => https://cal.com/pkaustria/parkour-einzeltraining?duration=90&date=2023-03-26 (19:00)

And there are also random timeslots missing, like 10:30 / 15:00 etc.

So I don't see the timeslots calculation working properly on my end :(

@Udit-takkar
Copy link
Contributor

@AUT-TOM yeah the PR is in production. Not sure why it is not working cc: @emrysal

@AUT-TOM
Copy link
Author

AUT-TOM commented Mar 24, 2023

can someone re-open the ticket or give any feedback here?

I think the calculation of bookable timeslots is a core functionality and if it's broken, there should be some attention on it.

@PeerRich

@Udit-takkar Udit-takkar reopened this Mar 24, 2023
@kortenkamp
Copy link

I can confirm that there is still a problem – it looks like current appointments (which are in my calendar as "Mitteleuropäische Zeit", but are in daylight saving time) are miscalculated by one hour.

@PeerRich PeerRich removed the linear Sync Github Issue from community members to Linear.app label May 26, 2023
@PeerRich PeerRich added bookings area: bookings, availability, timezones, double booking and removed availability labels Jun 19, 2023
@keithwillcode keithwillcode assigned emrysal and unassigned Udit-takkar Jun 22, 2023
@keithwillcode keithwillcode added this to the v3.1 milestone Jun 22, 2023
@emrysal
Copy link
Contributor

emrysal commented Jul 4, 2023

Hi @kortenkamp we've worked on this for a while in silence but I've just marked this issue to be fixed by a PR that is intended to rework and simplify our slot rendering - thank you for your patience

@kortenkamp
Copy link

Thanks for the update!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working High priority Created by Linear-GitHub Sync
Projects
None yet
6 participants