Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape "cube" is not available in the autocomplete #30

Open
tammy opened this issue Oct 21, 2018 · 2 comments
Open

Shape "cube" is not available in the autocomplete #30

tammy opened this issue Oct 21, 2018 · 2 comments

Comments

@tammy
Copy link
Member

tammy commented Oct 21, 2018

image

@tammy tammy self-assigned this Oct 21, 2018
@tammy tammy changed the title Shape "cube" is not available in the editor Shape "cube" is not available in the auto-complete Oct 21, 2018
@tammy tammy changed the title Shape "cube" is not available in the auto-complete Shape "cube" is not available in the autocomplete Oct 21, 2018
@tammy
Copy link
Member Author

tammy commented Oct 21, 2018

Just decided to compile regardless of whether it was being autocompleted, and it still works. Not sure if we're supposed to regenerate the autocomplete suggestions with each new version of calder?

@davepagurek
Copy link
Member

Ah yeah autocompletion is super hacky right now, basically we just give a list of words we want to be able to autocomplete in https://github.com/calder-gl/playground/blob/master/src/frontend/Completion.ts.

There's very little documentation on implementing code completion, but the gist of it is that you fill out the API for the completion function they provide here: securingsincity/react-ace#69. If we want to be a little more advanced than just having a list of recognized words, we could maybe use the position field to find the previous term, and if it's Shape, only show shape things? But I guess that's a nice-to-have. In the short term, just adding all the shape commands and generator commands to the list of completion words is still good.

@tammy tammy removed their assignment Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants