Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda package for mgatk and improving error messages #88

Closed
TomSmithCGAT opened this issue Mar 4, 2024 · 1 comment
Closed

Conda package for mgatk and improving error messages #88

TomSmithCGAT opened this issue Mar 4, 2024 · 1 comment

Comments

@TomSmithCGAT
Copy link

Would you consider making a conda package for mgatk? In the process of trying to resolve #70, I've been going through the code, and have a couple of observations.

  1. A lot of the common issues relate to the working environments not being set up appropriates (mainly versions of Java, R package).
  2. mgatk often fails silently, e.g no message on the command line. Even the snakemake log file is often not particularly helpful. I've had to resort to print statements to the snakemake run block to work out where the error was occuring.

(1) could be solved by making mgatk available via conda. I expect this would massively reduce the number of issues relating to working environments not being set up appropriately. This would also allow you to remove picard from the bin directory and just include it as a dependency, which is more sustainable.

(2) At the least, it would be helpful to ensure an error is propogated to the command line when the snakemake pipeline fails. I'm not proficient enough in snakemake to say how the errors in the log could be made more informative, but that would be helpful if possible.

@caleblareau
Copy link
Owner

Thanks for the interest in this-- it seems like there is a community sourced version now. If I can add anything to the official repo just lmk.

I agree the error handling could be better and am working on that now...
https://bioconda.github.io/recipes/mgatk/README.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants