Adds a deprecation warning for drop-down-icon #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another Easter Egg 😆 😆 Thanks 👍 👍 |
| @@ -6,6 +6,7 @@ import FontIcon from './font-icon'; | |||
| import Menu from './menu/menu'; | |||
| import DefaultRawTheme from './styles/raw-themes/light-raw-theme'; | |||
| import ThemeManager from './styles/theme-manager'; | |||
| import warning from './warning'; | |||
There was a problem hiding this comment.
import warning from 'warning';There was a problem hiding this comment.
Geeze! Thanks much 👍
|
Good idea 👍. |
This component really should have had a deprecation warning from 0.14.0 when the old `./menu/menu` implementation was deprecated. This component is not used in any other components in src or docs. It also is not documented on the site. I think we should add this warning ASAP and plan for removal along with `./menu/menu` in our first `0.15.0` release candidate.
newoga
force-pushed
the
deprecate-DropDownIcon
branch
from
a939dca to
4a2cb00
Compare
|
@alitaheri I think that we can merge it. |
|
@newoga Thanks 👍 👍 |
alitaheri
added a commit
that referenced
this pull request
Jan 21, 2016
Adds a deprecation warning for drop-down-icon
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component really should have had a deprecation warning from
0.14.0when the old./menu/menuimplementation was deprecated. This component is not used in any other components in src or docs. It also is not documented on the site. I think we should add this warning ASAP and plan for removal along with./menu/menuin our first0.15.0release candidate.