Customizable Babel Configuration for Modules #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppeg
force-pushed
the
reusable-babel-evaluate
branch
from
d9d9f74 to
02ebf48
Compare
|
Hey @giuseppeg, thank you for your pull request 🤗. |
satya164
reviewed
Oct 12, 2018
| @@ -57,7 +57,8 @@ const resolve = (path, t, requirements) => { | |||
| module.exports = function evaluate( | |||
| path /* : any */, | |||
| t /* : any */, | |||
| filename /* : string */ | |||
| filename /* : string */, | |||
| module /* : ?Module */ = null | |||
There was a problem hiding this comment.
Is there a reason you want to customize the module instance? I was thinking that you just add an argument for a custom transform function here, and then do something like m.transform = transform: https://github.com/callstack/linaria/blob/master/src/babel/evaluate.js#L150
There was a problem hiding this comment.
because otherwise I cannot patch transform when i use evaluate.js - you create an instance of Module inside of the function
There was a problem hiding this comment.
but yeah i could pass a transform function instead
|
Closing in favor of #247 |
satya164
pushed a commit
that referenced
this pull request
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #242
This change is backwards compatible and should allow to reuse the helper from
src/babel/evaluate.jsby making the the babel configuration used inModulecustomizable.