Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module): fixes a conflict between old ignore option and the new one #578

Merged
merged 1 commit into from
Apr 17, 2020
Merged

fix(module): fixes a conflict between old ignore option and the new one #578

merged 1 commit into from
Apr 17, 2020

Conversation

Anber
Copy link
Collaborator

@Anber Anber commented Apr 17, 2020

This PR fixes a conflict between ignore options (#575).

@Anber
Copy link
Collaborator Author

Anber commented Apr 17, 2020

@jayu do we need a second PR, or we can just cherry-pick changes?

jayu
jayu approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@jayu jayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-pick is ok

@Anber Anber merged commit 836481d into 1.4.x Apr 17, 2020
@thymikee thymikee deleted the issue-575 branch April 17, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayu jayu jayu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anber @jayu