fix(esbuild): workaround to for esbuild compile options #784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using esbuild with preact the jsxFactory and jsxFragment parameter are used to use h() rather than React.createElement(). This change ensures that the parameters are passed to the transform function.
Summary
This workaround checks if jsxFactory or jsxFragment are part of the original build options and if so copies them to to the transform options.
NOTE 1: Usually esbuild would just pick up on tsconfig.json - this workaround won't work there. The pararmeters must be provided explicitly.
NOTE 2: The plugin should probably be rewritten on a more fundamental
level as it interefers heavily with the esbuild build process.
Test plan
Setup an esbuild sample project with preact and linaria, then use this build script and check that there is no "React.createElement" in the bundle: