fix(esbuild): add missing resolveDir to support webfont bundling #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to bundle a font before, esbuild would complain:
> linaria:App_hash.linaria.css:1:46: error: Could not resolve "./font.ttf" (the plugin "linaria" didn't set a resolve directory)
1 ? @font-face{font-family:"font";src:url("./font.ttf");}...
With this fix the resolveDir is set to the basedir of the file loading
the font (or other external asset) and thus relative paths should work
just fine.
Note: When testing this configure the esbuild build to include the
appropriate loader, e.g.:
loader: { ".ttf": "dataurl" },
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When attempting to bundle a font before, esbuild would complain:
Summary
With this fix the
resolveDiris set to the basedir of the file loading the font (or other external asset) and thus relative paths should work just fine.Test plan
Note: When testing this, configure the esbuild build to include the appropriate loader, e.g.: