Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove imports from expo #1119

Closed
raajnadar opened this issue Jun 9, 2019 · 2 comments
Closed

Remove imports from expo #1119

raajnadar opened this issue Jun 9, 2019 · 2 comments

Comments

@raajnadar
Copy link
Collaborator

Remove imports from expo package

expo/expo#4501 to remove this warning.

global.__expo && global.__expo.Constants

if (global.__expo && global.__expo.Icon && global.__expo.Icon.MaterialIcons) {

@brentvatne
Copy link
Contributor

brentvatne commented Jun 9, 2019

not necessary to remove these as we have patched the expo global to not raise these warnings in expo@33.0.4. in the future when optional imports are supported in metro we can get rid of the global and instead just wrap an import with try/catch to make it optional

@ferrannp
Copy link
Collaborator

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants