fix: card title with 1 line only #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @IngenieroLata, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
It shouldn't be configurable. We should always pass 1 to Title. #1576 introduced the bug. |
|
Ok, I'll default it to 1 then. EDIT: @jaulz Or do you mean leave it a hardcoded 1, with no optional multiline prop? |
|
@IngenieroLata I agree to @Trancever and it should not be configurable. |
|
Right! roger that |
|
@jaulz Done! and just updated Motivation for future revisions |
diego-toro
changed the title
Trancever
approved these changes
Apr 17, 2020
|
Thanks! |
Trancever
pushed a commit
that referenced
this pull request
Apr 17, 2020
marchenk0va
pushed a commit
to marchenk0va/react-native-paper
that referenced
this pull request
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Card titles should be always 1 line. Per #1576 discussion.