fix: prevent FABGroup click when its hidden #1845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1816
FAB in FAGBroup is clickable when group is closed/hidden. It also happens when passing
visible={false}
.See below screen to see what is the issue (observe the pointer) :
Motivation
I have passed
visible={open}
prop from FABGroup to FAB to set pointer events on fab tonone
Also depend on
open
state I change pointerEvents in FABGroup tobox-none
ornone
. Put therenone
cause that FAB in Group is not pressable on Android.Screenshots
After proposed changes it looks like below:
Web
iOS
Android
Test plan
You can try to test after paste below code in example app in
FABExample.tsx
:Then do as follow:
Web
visible
prop in example tofalse
iOS/Android
visible
istrue
and group is open