fix: catch empty touches #2029
Merged
fix: catch empty touches #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here |
Trancever
suggested changes
Jun 30, 2020
| : e.pageY; | ||
| const { changedTouches, touches } = e.nativeEvent; | ||
| const touch = touches?.[0] || changedTouches?.[0]; | ||
| const startX = touch.pageX || e.pageX; |
There was a problem hiding this comment.
This will cause bugs if touch.pageX is 0. Can we handle this case?
There was a problem hiding this comment.
Very good catch 😊 I just fixed it.
Trancever
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are situations when the
touchesarray is empty and thus it causes errors.As I noticed it especially with
react-native-web@^0.13.0I checked their code and they have a similar check:https://github.com/necolas/react-native-web/blob/master/packages/react-native-web/src/hooks/usePressEvents/PressResponder.js#L548-L557
Test plan
Unfortunately, I cannot provide an example that reproduces the issue but I noticed it once in a while with
react-native-web@^0.13.0.