Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set input min width #3941

Merged
merged 4 commits into from
Sep 18, 2023
Merged

fix: set input min width #3941

merged 4 commits into from
Sep 18, 2023

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Jun 16, 2023

Fixes: #3811 #4039

Summary

Setting input min width, to be properly displayed for shorter label and placeholers

Test plan

Updated snapshots

@callstack-bot
Copy link

callstack-bot commented Jun 16, 2023

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@lukewalczak lukewalczak force-pushed the fix/input-min-width branch from 6498e3b to 35ac181 Compare June 19, 2023 13:33
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here.

Copy link
Collaborator

@tjaniczek tjaniczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg, how good that Accordion is 🎉

src/components/TextInput/TextInput.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here.

@lukewalczak lukewalczak merged commit 761e3cb into main Sep 18, 2023
@lukewalczak lukewalczak deleted the fix/input-min-width branch September 18, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextInput outlined strange inside a view
3 participants