feat: option for hiding check icon on selected chip #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Big-Cheung, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
Hey @Big-Cheung, you have to adjust spacings when the selected icon is hidden since those are not equal then (check the first 3 
|
added 2 commits
July 11, 2023 13:35
variable renamed for consistency with SegmentedButton
|
Good catch! Adjusted the spacing to use normal spacing. I also renamed the prop to be consistent with SegmentedButton. |
lukewalczak
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added optional prop for enabling/disabling default checkmark icon when selecting a chip.
Test plan
Testable using a Chip component with a selected item. The check mark next to the selected chip should be hidden if the prop option "showSelectedIcon" is set to false, and shown if the option is set to true. It is set to true by default.