Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct overriding border radius #3996

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

lukewalczak
Copy link
Member

Fixes: #3924

Summary

Allow customizing borderRadius value in Card.Cover.

Test plan

Adding new example and unit test case.

@callstack-bot
Copy link

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here.

@lukewalczak lukewalczak added this to the 5.10.0 milestone Jul 25, 2023
@lukewalczak lukewalczak merged commit a1c1107 into main Aug 2, 2023
@meatnordrink
Copy link
Contributor

meatnordrink commented Dec 14, 2023

I am noticing what might be an unintended side-effect to this improvement; now, if you pass in rounding to a single corner (as we were already doing in a number of places), that value becomes the default for all corners of the <Card.cover>. For example, this is what we're seeing, after upgrading and pulling in this work:

  cardCover: {
    borderTopRightRadius: 8, /* All four borders have 8px rounding */
    }

It's possible that this is the intended behavior, I suppose, as I can see an argument for it. And the work around is simple, just passing in values for each corner, e.g.

  cardCover: {
    borderTopRightRadius: 8,
    borderTopLeftRadius: 0,
    borderBottomRightRadius: 0,
    borderBottomLeftRadius: 0,
  },

If it was intentional, no worries; just figured I'd check that it was. If it wasn't, let me know and I could look at submitting a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to remove bottom border radius on Card.Cover
4 participants