Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with creator with only family name #80

Closed
tmorrell opened this issue Oct 3, 2024 · 2 comments
Closed

Bug with creator with only family name #80

tmorrell opened this issue Oct 3, 2024 · 2 comments
Assignees
@rsdoiel

Comments

@tmorrell
Copy link
Member

tmorrell commented Oct 3, 2024

A CrossRef entry that has just a family name

{
ORCID: "http://orcid.org/0000-0002-2787-1012",
authenticated-orcid: false,
family: "Divyajyoti",
sequence: "additional",
affiliation: [ ]
},

Should be mapped to RDM creator type personal.

I think this should added as an if else here

irdmtools/crossref.go

Line 276 in 2119b53

} else {
with just author.Family != ""
@rsdoiel
Copy link
Member

rsdoiel commented Oct 3, 2024

Fixed in upcoming v0.0.89 release.

@rsdoiel rsdoiel closed this as completed Oct 3, 2024
@rsdoiel
Copy link
Member

rsdoiel commented Oct 3, 2024

Tested using DOI https://doi.org/10.3847/1538-4357/ad65ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsdoiel rsdoiel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsdoiel @tmorrell