Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues: use the nicer runner #1770

Closed
Tracked by #1764
anshumanmohan opened this issue Nov 10, 2023 · 0 comments · Fixed by #1816
Closed
Tracked by #1764

Queues: use the nicer runner #1770

anshumanmohan opened this issue Nov 10, 2023 · 0 comments · Fixed by #1816
Labels
C: Queues One of the queue-style frontends

Comments

@anshumanmohan
Copy link
Contributor

anshumanmohan commented Nov 10, 2023

In #1736 I did some work that has cleaned up the "queue caller" routine. Nothing particularly deep happened there, I just got a tiny bit better at using the eDSL and thinking Calyx-ily. To make development easier, I made all my changes in a separate method (which assumes that you wish to create a non-main component that will be invoked repeatedly by another component) and left the other uses of the queue caller to use the old style (which assumes that you wish to create a main component that runs a list of commands to completion).

This is an issue to remind me to catch the other users of the queue caller up to the new style. The two methods can just be unified, with a flag or two to indicate whether the eDSL method is constructing a main-style component or a regular component.

Originally posted by @anshumanmohan in #1736 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Queues One of the queue-style frontends
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant