Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icarus-verilog to test suite. #755

Open
cgyurgyik opened this issue Oct 28, 2021 · 8 comments
Open

Add icarus-verilog to test suite. #755

cgyurgyik opened this issue Oct 28, 2021 · 8 comments
Labels
C: Calyx Extension or change to the Calyx IL S: Available Can be worked upon

Comments

@cgyurgyik
Copy link
Collaborator

I think it would be a good idea to add a few tests (one specifically for sqrt) for the icarus-verilog backend. Perhaps benchmarks as well? This would require some additions to the Github Actions.

@cgyurgyik cgyurgyik added the S: Discussion needed Issues blocked on discussion label Oct 28, 2021
@cgyurgyik
Copy link
Collaborator Author

The other option would be to run all the tests through both verilog and icarus-verilog.

@rachitnigam
Copy link
Contributor

I think it'd be better to make icarus-verilog tests run in the integration test suite? In general, icarus is faster than Verilator so at some point, it'd make sense to switch the default test suite to icarus. However, let's do that once we're convinced that Calyx programs obey icarus semantics.

@cgyurgyik
Copy link
Collaborator Author

The parallel example I was imagining is running C++ tests with multiple compilers (Clang, MSVC, ...) since compilation on one does not guarantee compilation on the other.

@rachitnigam
Copy link
Contributor

The parallel example I was imagining is running C++ tests with multiple compilers (Clang, MSVC, ...) since compilation on one does not guarantee compilation on the other.

Where did you talk about parallel examples?

@cgyurgyik
Copy link
Collaborator Author

The other option would be to run all the tests through both verilog and icarus-verilog.

I'm providing insight on why I mentioned this.

@rachitnigam
Copy link
Contributor

Hm, I think it's better to prioritize making Calyx programs work with multiple simulators instead of multiple C++ compilers. In some sense, if the latter doesn't work, it's compilers disagreeing on the semantics of C++; if the former doesn't work, it's simulators disagreeing on the semantics of Calyx.

@cgyurgyik
Copy link
Collaborator Author

Yes That's what I mean. The test suite should run through both verilog and iverilog, instead of one or the other.

@rachitnigam
Copy link
Contributor

Given that we have started recommending Icarus verilog in our getting started document, this is even more necessary now.

@rachitnigam rachitnigam added C: Calyx Extension or change to the Calyx IL S: Available Can be worked upon and removed S: Discussion needed Issues blocked on discussion labels Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Calyx Extension or change to the Calyx IL S: Available Can be worked upon
Projects
None yet
Development

No branches or pull requests

2 participants