-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icarus-verilog to test suite. #755
Comments
The other option would be to run all the tests through both verilog and icarus-verilog. |
I think it'd be better to make icarus-verilog tests run in the integration test suite? In general, icarus is faster than Verilator so at some point, it'd make sense to switch the default test suite to icarus. However, let's do that once we're convinced that Calyx programs obey icarus semantics. |
The parallel example I was imagining is running C++ tests with multiple compilers (Clang, MSVC, ...) since compilation on one does not guarantee compilation on the other. |
Where did you talk about parallel examples? |
I'm providing insight on why I mentioned this. |
Hm, I think it's better to prioritize making Calyx programs work with multiple simulators instead of multiple C++ compilers. In some sense, if the latter doesn't work, it's compilers disagreeing on the semantics of C++; if the former doesn't work, it's simulators disagreeing on the semantics of Calyx. |
Yes That's what I mean. The test suite should run through both verilog and iverilog, instead of one or the other. |
Given that we have started recommending Icarus verilog in our getting started document, this is even more necessary now. |
I think it would be a good idea to add a few tests (one specifically for
sqrt
) for the icarus-verilog backend. Perhaps benchmarks as well? This would require some additions to the Github Actions.The text was updated successfully, but these errors were encountered: