Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage and Control the use of non-negative amounts #153

Closed
PedroDiez opened this issue May 7, 2024 · 2 comments · Fixed by #152
Closed

Manage and Control the use of non-negative amounts #153

PedroDiez opened this issue May 7, 2024 · 2 comments · Fixed by #152
Labels
enhancement New feature or request

Comments

@PedroDiez
Copy link
Collaborator

PedroDiez commented May 7, 2024

Problem description
Within carrier_billing.yaml monetary amounts MUST be positive. Negative values do not make sense and also "zero" value is not indeed a payment.

Due to this, proposed solution considers to set minimum value for "amount" fields to 0.001. In the API Spec this would be:

... amount: type: number format: float **_minimum: 0.001_** multipleOf: 0.001 description: Amount to be charged or reserved. example: 100 ...

NOTE:

Possible evolution
Taking advantage of Open #152, it is proposed to deal with this issue within Carrier Billing v0.3.0 and new Refund Interface.

Alternative solution
Include as a Fix for carrier_billing.yaml v0.2.1 separately

Additional context

N/A

@PedroDiez PedroDiez added the enhancement New feature or request label May 7, 2024
@PedroDiez
Copy link
Collaborator Author

cc @bigludo7, @rartych, @eragaji (please mention here Barath if he owns github account)

@PedroDiez
Copy link
Collaborator Author

Also to consider for taxAmount, in order to not be negative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant