Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent statements about 405 status code in API Guidelines and CAMARA_common.yaml #285

Open
hdamker opened this issue Aug 16, 2024 · 2 comments
Labels
correction correction in documentation Spring25

Comments

@hdamker
Copy link
Collaborator

hdamker commented Aug 16, 2024

Problem description

405 error response is defined in CAMARA_common.yaml, but the API Design Guideline says in chapter 3.2. HTTP response codes:

This code is documented at the API portal level, it should not be documented at the API level.

I consider that as correct, as if a method is documented at API level it is obviously allowed and the method shouldn't return 405 on the resource.

But 405 is included in chapter 6.1 and CAMARA_common.yaml.

Expected behavior

  • Chapter 6.1 repeats the statement that this code should not be documented at the API level
  • 405 will not be listed within CAMARA_common.yaml (as the resource server has no influence on the details of the API GW response) to avoid that it is documented on API level.

Alternative solution

If there are valid use cases for a 405 reponse on a method which is defined in the API spec, they should be mentioned within the API Guidelines in chapter 6.1. The current response message is from my perspective not correct or can't be influenced by CAMARA.

Additional context

https://www.rfc-editor.org/rfc/rfc9110.html#name-status-codes:

15.5.6. 405 Method Not Allowed

The 405 (Method Not Allowed) status code indicates that the method received in the request-line is known by the origin server but not supported by the target resource. The origin server MUST generate an Allow header field in a 405 response containing a list of the target resource's currently supported methods.

@hdamker hdamker added the correction correction in documentation label Aug 16, 2024
hdamker referenced this issue in camaraproject/ConnectivityInsights Aug 16, 2024
@PedroDiez
Copy link
Collaborator

Think we can formally take actions in the next MetaRelease and for the current one MetaRelease just to ensure no one API has defined this error within the yaml

@hdamker
Copy link
Collaborator Author

hdamker commented Aug 19, 2024

Think we can formally take actions in the next MetaRelease and for the current one MetaRelease just to ensure no one API has defined this error within the yaml

There currently four APIs within the repositories which have defined the error response 405 within their YAML:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction correction in documentation Spring25
Projects
None yet
Development

No branches or pull requests

3 participants