Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geofencing - Align with new model #200

Closed
bigludo7 opened this issue Jun 4, 2024 · 3 comments · Fixed by #202
Closed

Geofencing - Align with new model #200

bigludo7 opened this issue Jun 4, 2024 · 3 comments · Fixed by #202
Labels
correction Fall24 Meta-release Fall24

Comments

@bigludo7
Copy link
Collaborator

bigludo7 commented Jun 4, 2024

Problem description
We have decided some months ago to move to CloudsEvent model for subscription. Now, the documentation is available in commonalities, in the design document, and with a yaml template.

Our Geofencing API should now be updated accordingly to this new model.

Expected behavior

Align geofencing API with this model.
This move will de facto solve #124

Alternative solution

Additional context

@maxl2287 as you did a great job on this API could we expect you to continue the work for this issue?

@maxl2287
Copy link
Contributor

maxl2287 commented Jun 4, 2024

I will take it in account and try to resolve it asap 🫡

@maxl2287
Copy link
Contributor

maxl2287 commented Jun 6, 2024

@bigludo7 PR is open, if you want to take a look. 🚀

@bigludo7
Copy link
Collaborator Author

bigludo7 commented Jun 7, 2024

@bigludo7 PR is open, if you want to take a look. 🚀

Thanks @maxl2287 ! This is great.
I've also do the same work for simswap-subscription so if you can take a look here.
As we're both 'pionner' on this work probably good that we're aligned :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction Fall24 Meta-release Fall24
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants