Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geofencing-subscriptions]: Remove "allOf" for sinkCredential in SubscriptionRequest #264

Closed
maxl2287 opened this issue Oct 9, 2024 · 0 comments · Fixed by #265
Closed
Assignees

Comments

@maxl2287
Copy link
Contributor

maxl2287 commented Oct 9, 2024

Problem description
Currently the sinkCredential has a not needed allOf here in the request.

        sinkCredential:
          allOf:
            - description: A sink credential provides authentication or authorization information necessary to enable delivery of events to a target.
            - $ref: "#/components/schemas/SinkCredential"

Commonalities:
https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.yaml#L299-L300

        sinkCredential:
          $ref: "#/components/schemas/SinkCredential"

Expected behavior
Remove the allOf and move the description to the SinkCredential-component

        sinkCredential:
          $ref: "#/components/schemas/SinkCredential"

<....>


    SinkCredential:
      description: A sink credential provides authentication or authorization information necessary to enable delivery of events to a target.
      type: object
      properties:
        credentialType:
          type: string
          enum:
            - PLAIN
            - ACCESSTOKEN
            - REFRESHTOKEN
          description: "The type of the credential."
      discriminator:
        propertyName: credentialType
        mapping:
          PLAIN: "#/components/schemas/PlainCredential"
          ACCESSTOKEN: "#/components/schemas/AccessTokenCredential"
          REFRESHTOKEN: "#/components/schemas/RefreshTokenCredential"
      required:
        - credentialType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant