-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent statements about applicable authorization flows #131
Comments
I will just refer to Telefonica's position when issue #92 was originally discussed. #92 (comment)
Thank you @hdamker for bringing this up. I also added a v0.2.0 label. |
Hi, Regarding the case of Personal Information but no opt-in nor opt-out required. We have some doubts about how interoperability can be solved in cases like: e.g.: Operator1 says dpv:FraudPrevention do not require opt-in nor opt-out; Operator2 says that opt-out is required. So 3-legged vs 2-legged being offered depending on the Operator?. This is why we did not oppose to less interpretative approach of "personal data processed or not". |
Interoperability and how to achieve it, isn't the subject of this issue. The default might be 3-legged, and 2-legged only used if agreed between "API Client and the Telco Operator exposing the API". If there is such an agreement then there is also not an interoperability issue (might be that the Telco has to offer both ways then, as other API Clients need 3-legged for interoperability. |
Two comments here:
|
Yes and no, if we define something that makes interoperability difficult or does not make clear how to be achieved, we would not be doing the best. You're right about the agreement, but in OpenGateway scenario we should not tell Channel Partners / developers that each operator offer different option and Channel Partner /developers behaves different. Anyway please notice I was just reflecting why we didn't oppose to more restrictive approach. |
I'm not an expert in laws, so I better clarify myself. Purpose has to be reflected and audited when personal info is accessed or managed. How to achieve it is not said in the law as law is not technical, different options may exist. GDPR or other laws does not say as far as I know that purpose has to be sent in each authorization request. |
@diegogonmar It's known that you / Telefonica are about following a more restrictive approach. But it was also you who insisted to stop questioning the agreement. Therefore I would really appreciate that you are also following this line and support that the document is consistent with the agreement. BTW: I tend to agree with you in Open Gateway scenarios as I wrote already above, but the guidelines shouldn't hinder any operator or other network provider to use the API also outside of Open Gateway with 2-legged authentication if this is legally possible in a scenario (e.g. within non-public networks). Or in other words: OGW can be more restrictive but CAMARA shouldn't. |
Hi @hdamker. I have two suggestions for way forward.
Then reopen issue to discuss about client credentials and usage of purposes.
Then reopen issue to discuss about client credentials and usage of purposes in scenarios where personal user data is processed. Or have this discussion as a part of general purposes discussion. Would it work for you to do either 1) or 2)? The PR needed in any of the options would need to also update other places already indicating same restriction. @eric-murray you raised the issue and PR that eventually added extra restriction. In both proposals I don't suggest to just revert it and do nothing, but a mean to move to former consensus point and then agree and reformulate approach for client credentials scenario with/without personal information. |
@diegogonmar sorry for my late reaction, I got too many notifications from GitHub in the last weeks ... To be able to restart the discussion clean, I propose to close the issue here and I create a new one to lift the additional restriction, with a summary of the discussion and a proposal based on your text above (which I not fully agree with, but that's to be discussed then in the new issue). Would that be ok for you? |
Hi @hdamker, fine for me |
@diegogonmar @hdamker Hopefully not necessary if we agree that #155 already fixes this. |
@jpengar I agree, let's aim to make it there consistent. With that I close the issue here. |
Problem description
Commit 7675e3e in PR #92 introduced a restriction for the use of Client Credentials into the CAMARA-API-access-and-user-consent.md document which goes beyond the clear documented guideline. It states that "client_credentials grant type ... can only be used when no personal user data is processed". This is not in line with the agreed guideline.
The agreed guideline was discussed several weeks, even in the TSC, and was reviewed by many people:
It is mandatory for all CAMARA API subprojects to adopt and to include in info.description property in the CAMARA API specs. Therefore it should be expected that also the I&CM working group is adhering to it in all statements.
The essence of the text is that CAMARA does not take legal decision about the specific authorization flows, but leaves that to "API Client and the Telco Operator exposing the API, taking into account the declared purpose for accessing the API, while also being subject to the prevailing legal framework dictated by local legislation". Beyond that it is making clear that "in cases where personal user data is processed by the API, and users can exercise their rights through mechanisms such as opt-in and/or opt-out, the use of 3-legged access tokens becomes mandatory". But CAMARA as technical project can't decide across all local legislation in which cases the users can exercise such rights and in which cases this isn't the case.
Expected behavior
commit 7675e3e, merged together with PR #92 should be reverted. If necessary a reference to the above guideline can be added.
The original PR text is still valid IMHO: if the client_credentials grant type will be used in cases where personal user information is processed (e.g. if the legal base is a law), than this has to been agreed already during the onboarding process, and both API Client and the Telco Operator exposing the API has taken into account the declared purpose for accessing the API.
Alternative solution
None, at least not without reverting the consensus about the above agreed guideline.Create a PR which will update the text to be in line with the agreed guideline.
Additional context
The issue was triggered by this discussion in PR #121, about a similar statement: #121 (comment)
Personal note: I agree that for most cases where a personal user resource is involved, 3-legged access tokens should be agreed. But we shouldn't make it mandatory if this would hinder certain use cases.
The text was updated successfully, but these errors were encountered: