Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test definitions - linting results #82

Closed
rartych opened this issue Aug 29, 2024 · 3 comments
Closed

Test definitions - linting results #82

rartych opened this issue Aug 29, 2024 · 3 comments
Assignees

Comments

@rartych
Copy link
Contributor

rartych commented Aug 29, 2024

Problem description
While testing linting rules for Gherkin the following output was produced

 1      Trailing spaces are not allowed                                                                 no-trailing-spaces
  32     Trailing spaces are not allowed                                                                 no-trailing-spaces
  46     Multiple empty lines are not allowed                                                            no-multiple-empty-lines
  58     Trailing spaces are not allowed                                                                 no-trailing-spaces
  69     Multiple empty lines are not allowed                                                            no-multiple-empty-lines
  84     Trailing spaces are not allowed                                                                 no-trailing-spaces
  95     Trailing spaces are not allowed                                                                 no-trailing-spaces
  107    Trailing spaces are not allowed                                                                 no-trailing-spaces
  118    Trailing spaces are not allowed                                                                 no-trailing-spaces
  138    Trailing spaces are not allowed                                                                 no-trailing-spaces
  148    Trailing spaces are not allowed                                                                 no-trailing-spaces
  159    Trailing spaces are not allowed                                                                 no-trailing-spaces
  170    Trailing spaces are not allowed                                                                 no-trailing-spaces
  181    Trailing spaces are not allowed                                                                 no-trailing-spaces
  192    Trailing spaces are not allowed                                                                 no-trailing-spaces
  203    Trailing spaces are not allowed                                                                 no-trailing-spaces
  217    Trailing spaces are not allowed                                                                 no-trailing-spaces
  227    Trailing spaces are not allowed                                                                 no-trailing-spaces
  237    Trailing spaces are not allowed                                                                 no-trailing-spaces
  239    Multiple empty lines are not allowed                                                            no-multiple-empty-lines
  253    Trailing spaces are not allowed                                                                 no-trailing-spaces
  255    Multiple empty lines are not allowed                                                            no-multiple-empty-lines
  270    Trailing spaces are not allowed                                                                 no-trailing-spaces
  277    Scenario name is already used in: OTPvalidationAPI.feature:261                                  no-dupe-scenario-names
  286    Trailing spaces are not allowed                                                                 no-trailing-spaces
  288    Multiple empty lines are not allowed                                                            no-multiple-empty-lines
  302    Trailing spaces are not allowed                                                                 no-trailing-spaces
  314    Trailing spaces are not allowed                                                                 no-trailing-spaces
  326    Trailing spaces are not allowed                                                                 no-trailing-spaces
  338    Trailing spaces are not allowed                                                                 no-trailing-spaces
  349    Trailing spaces are not allowed                                                                 no-trailing-spaces
  363    Scenario name is already used in: OTPvalidationAPI.feature:131                                  no-dupe-scenario-names
  371    Trailing spaces are not allowed                                                                 no-trailing-spaces
  374    Scenario name is already used in: OTPvalidationAPI.feature:141                                  no-dupe-scenario-names
  382    Trailing spaces are not allowed                                                                 no-trailing-spaces
  425    Scenario name is already used in: OTPvalidationAPI.feature:210                                  no-dupe-scenario-names
  432    Trailing spaces are not allowed                                                                 no-trailing-spaces
  434    Multiple empty lines are not allowed                                                            no-multiple-empty-lines
  436    Scenario name is already used in: OTPvalidationAPI.feature:220                                  no-dupe-scenario-names
  443    Trailing spaces are not allowed                                                                 no-trailing-spaces
  445    Multiple empty lines are not allowed                                                            no-multiple-empty-lines
  447    Scenario name is already used in: OTPvalidationAPI.feature:230                                  no-dupe-scenario-names
  454    Trailing spaces are not allowed                                                                 no-trailing-spaces
  456    Multiple empty lines are not allowed                                                            no-multiple-empty-lines
  462    Trailing spaces are not allowed                                                                 no-trailing-spaces
  469    Trailing spaces are not allowed                                                                 no-trailing-spaces
  472    Multiple empty lines are not allowed                                                            no-multiple-empty-lines
  478    Scenario name is already used in: OTPvalidationAPI.feature:261, OTPvalidationAPI.feature:277    no-dupe-scenario-names
  487    Trailing spaces are not allowed                                                                 no-trailing-spaces
  494    Scenario name is already used in: OTPvalidationAPI.feature:261, OTPvalidationAPI.feature:277, OTPvalidationAPI.feature:478    no-dupe-scenario-names
  503    Trailing spaces are not allowed                                                                 no-trailing-spaces

Expected behavior
The most of issues are related to formatting.
But the optional scenario title is indeed duplicated or repeated multiple times.

It should be considered to change the filename of test definitions to kebab-case.

Alternative solution

Additional context

@bigludo7 bigludo7 self-assigned this Aug 29, 2024
@bigludo7
Copy link
Collaborator

Thanks @rartych
done.

@bigludo7
Copy link
Collaborator

bigludo7 commented Sep 5, 2024

@rartych may I close this one ?

@rartych
Copy link
Contributor Author

rartych commented Sep 5, 2024

Yes, it was resolved with 5eed2d9

@rartych rartych closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants