-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to split QoS Sessions and QoS Profiles into two separate API definitions #265
Comments
For scope management it also makes sense to split the current API in 2, as QoS Profiles has no Personal Information, and QoS Profiles may be used in other APIs, not only for QoD sessions. |
QoD Call Feb 19th: Agreed to split the APIs Additionally discussed:
|
@hdamker do you think we can propose a PR already, or should we discuss further on the additional points? I would approach the task as:
|
I started with this task. The key point to discuss is which basePath and API version is applied tor each split API:
This is to be agreed prior to the PR |
Results from discussion of the above issue within the QoD Call on March 22nd:
Request for action: please raise your opinion regarding the right basepath here in the issue |
We have to decide also the title for the split yaml, which currently is "QoD for enhanced communication". It should be aligned with the baseBath, so we may choose "Quality on Demand" for the title, and But if we are moving to an approach where we have more granular APIs, as we are keeping only the endpoints under the tag "QoS sessions", another option would be So maybe deciding on the API title is more relevant. |
Problem description
We have currently within the QoD API (v0.10.0) two different resources:
description: Manage QoS sessions
description: Manage QoS Profiles
There are several arguments why it would make sense to split the API in two separate ones:
Possible evolution
Split the current API definition into two different
"QoS Sessions on Demand" (to be discussed to keep in the basepath
qod
for backward compatibility)"QoS Profiles"
Potentially define a YAML with common definitions between the APIs (if not already available within https://github.com/camaraproject/Commonalities/blob/main/artifacts/CAMARA_common.yaml)
Alternative solution
?
Additional context
From discussion within #244:
Splitting the API may have all sense. BTW, we are facing some new use cases where QoS profiles may be used by other APIs as well, so that would ease reusing this functionality.
Originally posted by @jlurien in #244 (comment)
The text was updated successfully, but these errors were encountered: