Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CarrierBillingCheckOut r1.2 release review (M4) #83

Closed
11 tasks done
hdamker opened this issue Aug 27, 2024 · 6 comments
Closed
11 tasks done

CarrierBillingCheckOut r1.2 release review (M4) #83

hdamker opened this issue Aug 27, 2024 · 6 comments
Assignees
Labels
review Review of a proposed release (e.g. release PR)

Comments

@hdamker
Copy link
Collaborator

hdamker commented Aug 27, 2024

Release PR or issue to review

camaraproject/CarrierBillingCheckOut#178

Review actions

Assign this issue to yourself and follow the below list.
For any review action, review the file(s) in the issue/PR listed above.
Put comments in the above issue or PR if they concern non-changed files/text.
Put a short summary of the main review result here into the review issue.

  • API definition files (YAML) (check version in info & servers objects)
  • test file(s) availability
  • changelog updated
  • readme updated (enforce correct release number / API version naming)
  • API readiness checklist(s)

Release actions

Assign this issue to yourself or another RM team member and follow the below list.
When done, tick the box in this issue.

  • API release tracker available on wiki
  • Review comments addressed (by Sub Project)
  • Release PR approved (on behalf of Release Management)
  • PR merged (by Sub Project codeowner)
  • Release created within GitHub (by Sub Project codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

Additional comments

@hdamker hdamker added the review Review of a proposed release (e.g. release PR) label Aug 27, 2024
@jlurien jlurien self-assigned this Sep 3, 2024
@jlurien
Copy link
Collaborator

jlurien commented Sep 3, 2024

@hdamker it seems I cannot edit the issue above to mark the validated tasks, am I missing anything?

@jlurien
Copy link
Collaborator

jlurien commented Sep 3, 2024

  • Test files not part of the PR, but already merged in main
  • Some APIs are adding "- rc" to "r1.1" in the Changelog, while other don't. There are no explicit instructions about this but it is not consistent across the project
  • API readiness checklists not updated to lastest versions

@hdamker
Copy link
Collaborator Author

hdamker commented Sep 4, 2024

@hdamker it seems I cannot edit the issue above to mark the validated tasks, am I missing anything?

Yes, write access to the repository 😃 ... fixed now, have granted all reviewers write access.

@jlurien
Copy link
Collaborator

jlurien commented Sep 4, 2024

Review actions completed

@jlurien
Copy link
Collaborator

jlurien commented Sep 6, 2024

All task completed

@tanjadegroot
Copy link
Collaborator

Thanks @jlurien for the RM review. This is can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Review of a proposed release (e.g. release PR)
Projects
None yet
Development

No branches or pull requests

3 participants