Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align sim-swap notification subscription Yaml with new subscription model #108

Closed
bigludo7 opened this issue May 29, 2024 · 2 comments · Fixed by #111
Closed

Align sim-swap notification subscription Yaml with new subscription model #108

bigludo7 opened this issue May 29, 2024 · 2 comments · Fixed by #111
Assignees

Comments

@bigludo7
Copy link
Collaborator

Problem description
Decision at commonalities level is to shift to CloudEvents model.
Template & documentation are provided.

Expected behavior
Modifiy sim-swap-notification-subscription.yaml accordingly to this new format.

Alternative solution

Additional context
To be done for the first meta release

@bigludo7 bigludo7 self-assigned this May 29, 2024
@gregory1g
Copy link
Collaborator

gregory1g commented Jun 5, 2024

What is a difference between the current design which is already CloudEvent based (in the master branch) and the "new format"?

Side not:
current spec includes the following notification event example:

examples:
SWAPPED:
value:
id: '123655'
source: supertelco.notificationSendServer12
type: org.camaraproject.sim-swap.v0.swapped
specversion: '1.0'
datacontenttype: application/json
data:
phoneNumber: 123456788
subscriptionId: 2ghy-55gg-7iup-yuo9
time: 2023-01-18T13:18:23.682Z
SUBSCRIPTION_ENDS:
value:
id: '123658'
source: supertelco.notificationSendServer12
type: org.camaraproject.sim-swap.v0.subscription-ends
specversion: '1.0'
datacontenttype: application/json
data:
phoneNumber: 123456789
terminationReason: SUBSCRIPTION_EXPIRED
subscriptionId: 2ghy-55gg-7iup-yuo9
terminationDescription: subscription expire time reached
time: 2023-01-19T13:18:23.682Z

As far as I understand phoneNumber must be a string and include leading "+", like
phoneNumber: "+123456788"

@bigludo7
Copy link
Collaborator Author

bigludo7 commented Jun 5, 2024

Hello @gregory1g
The change is not on the notification event but on the subscription resource.
Now that the PR has been merged you'll find the detail here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants