Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap Notification example list phoneNumber value without quotes #113

Closed
gregory1g opened this issue Jun 7, 2024 · 1 comment
Closed
Labels
documentation Improvements or additions to documentation

Comments

@gregory1g
Copy link
Collaborator

Problem description
event example included in "https://github.com/camaraproject/SimSwap/blob/main/code/API_definitions/sim-swap-notification-subscription.yaml" use phoneNumber without quotes (phoneNumber: +123456788), should be:
phoneNumber: "+123456788"


examples:
SWAPPED:
value:
id: "123655"
source: supertelco.notificationSendServer12
type: org.camaraproject.sim-swap.v0.swapped
specversion: "1.0"
datacontenttype: application/json
data:
phoneNumber: +123456788
subscriptionId: 2ghy-55gg-7iup-yuo9
time: 2023-01-18T13:18:23.682Z

SUBSCRIPTION_ENDS:
  value:
    id: "123658"
    source: supertelco.notificationSendServer12
    type: org.camaraproject.sim-swap.v0.subscription-ends
    specversion: "1.0"
    datacontenttype: application/json
    data:
      phoneNumber: +123456789
      terminationReason: SUBSCRIPTION_EXPIRED
      subscriptionId: 2ghy-55gg-7iup-yuo9
      terminationDescription: subscription expire time reached
    time: 2023-01-19T13:18:23.682Z

@gregory1g gregory1g added the documentation Improvements or additions to documentation label Jun 7, 2024
@bigludo7
Copy link
Collaborator

Fixed with #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants