Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MSISDN from request body #58

Closed
fernandopradocabrillo opened this issue Sep 25, 2023 · 3 comments
Closed

Remove MSISDN from request body #58

fernandopradocabrillo opened this issue Sep 25, 2023 · 3 comments
Assignees

Comments

@fernandopradocabrillo
Copy link
Collaborator

Problem description
With the use of 3-legged authorization flow, it is no longer necessary to send the phone number in the request body as it can be obtained from the token.

Expected behavior
The MSISDN will be obtained from the 3-legged token.

Alternative solution
N/A
Additional context
N/A

@DT-DawidWroblewski
Copy link
Collaborator

Hi @fernandopradocabrillo !

as client credentials is still an option MSISDN has to be passed in a resource request. However, I suggest using HTTP request header to pass the MSISDN value.

@chrishowell
Copy link

chrishowell commented Oct 5, 2023

I don't think we can remove the msisdn from request, there could very easily be scenarios where the target device (the msisdn in the request) is not the same as the authorisation device (the msisdn in the access token)

@fernandopradocabrillo
Copy link
Collaborator Author

Hi @chrishowell
In today's meeting we have agreed to leave it as an optional parameter in the request body.
I didn't have the time to update the PR yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants