Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading method parameters #42

Open
NFGomes opened this issue Jan 24, 2017 · 0 comments
Open

Misleading method parameters #42

NFGomes opened this issue Jan 24, 2017 · 0 comments

Comments

@NFGomes
Copy link

NFGomes commented Jan 24, 2017

The signature of the method

public static string Create(AuthenticationDetails auth, string clientID, string title, string unsubscribePage, bool confirmedOptIn, string confirmationSuccessPage, UnsubscribeSetting unsubscribeSetting)

on the List class has confirmedOptIn as one of the properties, this is some what misleading since when set to true you expect the list to be created with the recipients already confirmed but no, setting it to true means that the recipients need to confirm their subscription, setting confirmedOptIn to false creates the list with the recipients already confirmed.

In my opinion this can cause some confusion and changing it's name to confirmOptIn would help clearing some confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant