Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support extra accounts token generation #42

Merged
merged 2 commits into from
Apr 13, 2023
Merged

feat: support extra accounts token generation #42

merged 2 commits into from
Apr 13, 2023

Conversation

modridi
Copy link
Contributor

@modridi modridi commented Apr 12, 2023 •
edited
Loading

Description of the changes

Currently, a single account pipeline is created and given admin role and a token for API access. This PR allows passing a list of account names to the optional extra_accounts variable. Tokens are generated for these accounts for API access and returned using extra_tokens output.

Breaking change

  • No
  • Yes (in the Helm chart(s))
  • Yes (in the module itself)

Tests executed on which distribution(s)

  • KinD
  • AKS (Azure)
  • EKS (AWS)
  • Scaleway
  • SKS (Exoscale)

@modridi modridi marked this pull request as ready for review April 13, 2023 09:34
@modridi modridi requested a review from a team as a code owner April 13, 2023 09:34
@modridi modridi merged commit 762ce3e into main Apr 13, 2023
@modridi modridi deleted the token-generation branch April 13, 2023 15:34
@github-actions github-actions bot mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xaving Xaving Xaving approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modridi @Xaving