fix: mount ca cert also for letsencrypt-staging and parameterize secret key #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarascut
previously approved these changes
May 31, 2023
ckaenzig
reviewed
May 31, 2023
ckaenzig
reviewed
May 31, 2023
|
Can I have the time to better test this tomorrow before merging? I would like us to consider a bit more before adding a variable to set this, since the thing won't be activated unless one of the two defined cluster issuers is set. So in my view it would be better if each one of the cases has its on secret key instead of allowing the user to set it up. Like having a ternary operator: |
hbollon
force-pushed
the
fix/oidc-ca-certificate-staging
branch
from
99d02cd to
05f4da9
Compare
lentidas
requested changes
Jun 2, 2023
lentidas
approved these changes
Jun 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Currently, ArgoCD's OIDC won't work with
letsencrypt-stagingissuer since it's not issued by a known certificate authority and so ArgoCD return ax509 certificate signed by unknown authorityerror when trying to login via Keycloak.To fix that, I added the certificate volume mount to ArgoCD if the issuer is
letsencrypt-staging. I also parameterized the secret key used in it since in my case it's notca.crtbuttls.crt(the variable is still default to ca.crt)Breaking change
Tests executed on which distribution(s)