Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variable to set resources with default values #31

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

lentidas
Copy link
Contributor

@lentidas lentidas commented Apr 3, 2024

Description of the changes

This PR adds a variable to set resources' limits and requests on the module components.

Having default values is good practice to prevent that our components could eventually starve other workloads on the cluster. However, these should probably be adapted in production clusters and are only a safeguard in case someone forgets to set them.

Breaking change

  • No

Tests executed on which distribution(s)

  • EKS (AWS)

@lentidas lentidas self-assigned this Apr 3, 2024
@lentidas lentidas requested a review from a team as a code owner April 3, 2024 09:54
Having default values is good practice to prevent that our components could eventually starve other workloads on the cluster. However, these should probably be adapted in production clusters and are only a safeguard in case someone forgets to set them.
@lentidas lentidas merged commit 74c4327 into main Apr 17, 2024
@lentidas lentidas deleted the ISDEVOPS-259 branch April 17, 2024 11:18
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants