Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sks): type mismatch into coalesce call for nodepools definitions #891

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

hbollon
Copy link
Member

@hbollon hbollon commented Apr 8, 2022

On the SKS module, all optional fields to define nodepools could not be used due to a type mismatch between default_nodepool and var.nodepools in the coalesce function call.
This PR solve this but however it's now mandatory to have all fields defined even those not used (set on null) on nodepool creation. For exemple:

nodepools = {
  "is-internal-green" = {
    size            = 2
    instance_type   = "standard.large"
    description     = "Default nodepool for is-internal"
    instance_prefix = null
    disk_size       = null

    labels              = null
    taints              = null
    private_network_ids = null
  }
}

@hbollon hbollon merged commit 7dc6c32 into master Apr 26, 2022
@github-actions github-actions bot mentioned this pull request Apr 26, 2022
@fsismondi fsismondi deleted the fix/sks-nodepools-optionals-fields branch November 14, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants