Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generify naming of extract methods (sometimes extract.., other times extracting..) #217

Closed
Tracked by #189
remcowesterhoud opened this issue Feb 28, 2022 · 0 comments · Fixed by #235
Closed
Tracked by #189

Generify naming of extract methods (sometimes extract.., other times extracting..) #217

remcowesterhoud opened this issue Feb 28, 2022 · 0 comments · Fixed by #235
Assignees
@remcowesterhoud

Comments

@remcowesterhoud
Copy link
Contributor

remcowesterhoud commented Feb 28, 2022 •
edited
Loading

Description

Some of the assertion classes contain methods for extracting. The naming of these methods is inconsistent, sometimes they are called extractX and sometimes they are called extractingX.

My suggestion is to rename these all to extractingX. This introduces consistent naming, and it seems like extracting is used by assertJ.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remcowesterhoud remcowesterhoud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename extract methods to extracting camunda/zeebe-process-test
1 participant
@remcowesterhoud