Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy workflow stable branch compatibility #231

Closed
Tracked by #189
remcowesterhoud opened this issue Mar 3, 2022 · 1 comment · Fixed by #259
Closed
Tracked by #189

Deploy workflow stable branch compatibility #231

remcowesterhoud opened this issue Mar 3, 2022 · 1 comment · Fixed by #259

Comments

@remcowesterhoud
Copy link
Contributor

remcowesterhoud commented Mar 3, 2022

Description

We will have to support stable branches starting from the 1.4.0 release. Currently this will not work properly. This is because in our pipeline we have the "Build and deploy to Maven" step:

- name: Build and deploy to Maven
  id: release
  uses: camunda-community-hub/community-action-maven-release@v1.0.12
  with:
    release-version: ${{ github.event.release.tag_name }}
    release-profile: community-action-maven-release
    nexus-usr: ${{ steps.secrets.outputs.ARTIFACTS_USR }}
    nexus-psw: ${{ steps.secrets.outputs.ARTIFACTS_PSW }}
    maven-usr: ${{ steps.secrets.outputs.MAVEN_CENTRAL_DEPLOYMENT_USR }}
    maven-psw: ${{ steps.secrets.outputs.MAVEN_CENTRAL_DEPLOYMENT_PSW }}
    maven-gpg-passphrase: ${{ steps.secrets.outputs.MAVEN_CENTRAL_GPG_SIGNING_KEY_PASSPHRASE }}
    maven-url: s01.oss.sonatype.org
    github-token: ${{ secrets.GITHUB_TOKEN }}

One of the things this action does is updating the project version in the pom files. By default it does this change on the default branch, which in our case is main. At the moment I don't see a way to change this to a different branch. This means we have 2 options.

  1. We stop using this action and add our own steps for deploying to Maven.
  2. We make a change in the community-action-maven-release to support different branches. In our workflow we'd have to figure out which stable branch we need to use.
@remcowesterhoud
Copy link
Contributor Author

We have decided to go with option 2. The change on the community-action-maven-release has been merged (camunda-community-hub/community-action-maven-release#37). Once a new release of this action has been released we can go ahead with the changes on our side.

This involves:

  1. Adding a step to the pipeline to decide what branch should be used for the version update
  2. Pass the branch as input parameter to the release action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant