fix(broker): do not log transition failure due to term mismatch as error

If a transition failed due to a term mismatch, there will be a new transition following. There is no need to log it as an error because conceptually it is not an error. It is expected to fail to prevent inconsistencies. When this failure happens, it is ignored and ZeebePartition continue with the next transition.

(cherry picked from commit 713d2ee)

broker/src/main/java/io/camunda/zeebe/broker/system/partitions/ZeebePartition.java

@@ -250,7 +250,6 @@ private ActorFuture<Void> leaderTransition(final long newTerm) {
                 });
             onRecoveredInternal();
           } else {
-            LOG.error("Failed to install leader partition {}", context.getPartitionId(), error);
             onInstallFailure(error);
           }
         });
@@ -274,7 +273,6 @@ private ActorFuture<Void> followerTransition(final long newTerm) {
                 });
             onRecoveredInternal();
           } else {
-            LOG.error("Failed to install follower partition {}", context.getPartitionId(), error);
             onInstallFailure(error);
           }
         });
@@ -340,6 +338,7 @@ private void onInstallFailure(final Throwable error) {
           context.getPartitionId(),
           error.getMessage());
     } else {
+      LOG.error("Failed to install partition {}", context.getPartitionId(), error);
       handleRecoverableFailure();
     }
   }

broker/src/main/java/io/camunda/zeebe/broker/system/partitions/impl/PartitionTransitionProcess.java

@@ -84,9 +84,7 @@ private void proceedWithTransition(final ActorFuture<Void> future) {
 
   private void onStepCompletion(final ActorFuture<Void> future, final Throwable error) {
     if (error != null) {
-      LOG.error(error.getMessage(), error);
       future.completeExceptionally(error);
-
       return;
     }