Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch an escalation in an event subprocess start event #10690

Closed
Tracked by #10682
lzgabel opened this issue Oct 12, 2022 · 0 comments · Fixed by #10914
Closed
Tracked by #10682

Catch an escalation in an event subprocess start event #10690

lzgabel opened this issue Oct 12, 2022 · 0 comments · Fixed by #10914
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0

Comments

@lzgabel
Copy link
Contributor

lzgabel commented Oct 12, 2022 •
edited by remcowesterhoud
Loading

Is your feature request related to a problem? Please describe.
Thrown escalations can be handled in the workflow by catching it on an event subprocess.

image

Describe the solution you'd like

  • the escalation event contains an escalationCode (any string), optional
  • If escalationRef is omitted or escalationCode of referenced escalation is omitted, the event start event is triggered by any escalation event.
  • In case an escalationRef is set, the start event is only triggered by escalation events with the defined escalationCode.
  • The escalation code of the start event must be unique across the event sub-processes of the same scope. (part of I can deploy a process definition with escalation event #10688 validations)
  • If a start event has no escalationRef or escalationCode of referenced escalation then another event sub-process with an escalation start event in the same scope is not supported. (part of I can deploy a process definition with escalation event #10688 validations)
  • The escalation must be caught by the "nearest enclosing parent activity"
@lzgabel lzgabel added the kind/feature Categorizes an issue or PR as a feature, i.e. new behavior label Oct 12, 2022
@lzgabel lzgabel mentioned this issue Oct 12, 2022
Closed
15 tasks
@remcowesterhoud remcowesterhoud changed the title Catch an escalation on an event subprocess Catch an escalation in an event subprocess start event Oct 19, 2022
@lzgabel lzgabel mentioned this issue Nov 4, 2022
Merged
9 tasks
ghost pushed a commit that referenced this issue Nov 9, 2022
@lzgabel
merge: #10914
8bc4efe 
10914: feat: support escalation end events r=remcowesterhoud a=lzgabel

## Description
I can throw an escalation using an end event.

* Escalations thrown from a called activity or sub process can be handled by catching on a boundary event.
* Throw escalations can be handled by catching on an event subprocess.

## Related issues
closes #10686
closes #10684
closes #10690
closes #10763

## Definition of Done

Code changes:
* [x] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to [backport](https://github.com/camunda/zeebe/compare/stable/0.24...main?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/1.3`) to the PR, in case that fails you need to create backports manually.

Testing:
* [x] There are unit/integration tests that verify all acceptance criterias of the issue
* [x] New tests are written to ensure backwards compatibility with further versions
* [ ] The behavior is tested manually
* [ ] The change has been verified by a QA run
* [ ] The impact of the changes is verified by a benchmark

Documentation:
* [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
* [ ] If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our [review guidelines](https://github.com/camunda/zeebe/wiki/Pull-Requests-and-Code-Reviews#code-review-guidelines).


Co-authored-by: lzgabel <lz19960321lz@gmail.com>
@ghost ghost closed this as completed in 04caa89 Nov 9, 2022
@remcowesterhoud remcowesterhoud added the version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 label Dec 6, 2022
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support escalation end events lzgabel/zeebe
3 participants
@npepinpe @remcowesterhoud @lzgabel