Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set variables on Fail Job via Go client #10788

Closed
korthout opened this issue Oct 21, 2022 · 0 comments · Fixed by #10790
Closed

Set variables on Fail Job via Go client #10788

korthout opened this issue Oct 21, 2022 · 0 comments · Fixed by #10790
Assignees
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0

Comments

@korthout
Copy link
Member

Is your feature request related to a problem? Please describe.
Recently, we introduced the ability to set variables when failing a job to Zeebe. The FailJob RPC now supports passing these variables along. Additionally, the zeebe-java-client now provides an interface to pass variables along when failing a job, but the Go client was left out of scope.

Describe the solution you'd like
Add a way to pass variables along when failing a job via the Go client. Inspiration can be taken from other RPCs that support passing variables along like CompleteJob.

Describe alternatives you've considered
It's possible to add this support to zbctl once it's implemented in the Go client, but I don't see a need for it now. We can implement this in a separate issue if/when users ask for it.

Additional context
This functionality was implemented for the Java client in:

@korthout korthout added kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/clients-go labels Oct 21, 2022
@ghost ghost closed this as completed in 4498022 Nov 2, 2022
@remcowesterhoud remcowesterhoud added the version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 label Dec 6, 2022
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants