Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to open multiple message subscriptions for the same event #11308

Closed
korthout opened this issue Dec 20, 2022 · 3 comments · Fixed by #11994
Closed

Possible to open multiple message subscriptions for the same event #11308

korthout opened this issue Dec 20, 2022 · 3 comments · Fixed by #11994
Assignees
Labels
component/engine kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/low Marks a bug as having little to no noticeable impact for the user version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0

Comments

@korthout
Copy link
Member

Describe the bug

When a user deploys the same process multiple times without changes, additional message start event subscriptions are opened, if there are top-level message start events present in the process.

This does not lead to issues because published messages only create a single instance, but strangely, additional message subscriptions are opened.

Screen Shot 2022-12-20 at 18 18 03

Screen Shot 2022-12-20 at 18 22 43

To Reproduce

  • run Zeebe Play
  • deploy a simple process with a top-level message start event
  • deploy the same process again
  • in Zeebe Play, notice the secondary message subscription

Expected behavior

Only a single message subscription exist for any message event at any time.

@korthout korthout added kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/low Marks a bug as having little to no noticeable impact for the user labels Dec 20, 2022
@korthout
Copy link
Member Author

I'm giving this low severity because there is no user impact.

@skayliu
Copy link
Contributor

skayliu commented Mar 9, 2023

Hey, @korthout, i dig a little bit, when deploy the same process again, we can find the processesMetadata.duplicate is true.

We have check top-level time start event isDuplicate at DeploymentCreateProcessor.java#L129, bud the others are not.

Hey, @korthout @Zelldon could #6314 #6480 caused by this?

"processesMetadata":[
            {
                "version":6,
                "bpmnProcessId":"Process_0k1nnh5",
                "processDefinitionKey":2251799813685489,
                "checksum":"+tH+Q1NPNoxIlEKqMgHBQw==",
                "resourceName":"Process_0k1nnh5.bpmn",
                "duplicate":true
            }
        ]

@korthout
Copy link
Member Author

korthout commented Mar 9, 2023

@skayliu Thanks for looking into this.

We have check top-level time start event isDuplicate at DeploymentCreateProcessor.java#L129, bud the others are not.

👍 Good find! Adding that check for the other start event subscriptions could be a good solution.

This is not related.

This is not caused by this, but could probably be solved similarly using your suggestion.

ghost pushed a commit that referenced this issue Mar 21, 2023
11994: fix(engine): open single message or signal subscription for the same event r=korthout a=skayliu

## Description

When a user deploys the same process multiple times without changes, no additional message or signal start event subscriptions will be opened, if there are top-level message or signal start events present in the process.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #11308 



Co-authored-by: skayliu <skay463@163.com>
@ghost ghost closed this as completed in 3cd9594 Mar 21, 2023
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/engine kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/low Marks a bug as having little to no noticeable impact for the user version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants