Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce record distribution behavior #11660

Closed
Tracked by #11456
korthout opened this issue Feb 14, 2023 · 0 comments · Fixed by #11926
Closed
Tracked by #11456

Introduce record distribution behavior #11660

korthout opened this issue Feb 14, 2023 · 0 comments · Fixed by #11926
Assignees
@remcowesterhoud
Labels
component/engine kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0

Comments

@korthout
Copy link
Member

korthout commented Feb 14, 2023 •
edited
Loading

  • when it is called, it does the following:
    • checks if there even are other partitions, if not, return
    • writes STARTED event
    • writes DISTRIBUTING event for each partition
    • adds a post-commit task to send the command to the other partition with key and intent of wrapped command
    • de-deprecate the send command with key method

Depends on
@korthout korthout mentioned this issue Feb 14, 2023
Closed
3 tasks
@korthout korthout added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. component/engine labels Feb 14, 2023
@korthout korthout mentioned this issue Feb 14, 2023
Closed
@remcowesterhoud remcowesterhoud self-assigned this Mar 3, 2023
@remcowesterhoud remcowesterhoud mentioned this issue Mar 3, 2023
Merged
14 tasks
ghost pushed a commit that referenced this issue Mar 7, 2023
@remcowesterhoud
merge: #11926
102a6ba 
11926: Add command distribution behavior r=remcowesterhoud a=remcowesterhoud

## Description

<!-- Please explain the changes you made here. -->

This PR introduces the `CommandDistributionBehavior` this behavior is responsible for distributing commands in a generic way.

Note, this code is untested as of now. Since we test engine behavior and not specific behavior implementations it will be tested when we've switched the `DeploymentCreateProcessor` to this new way of distributing.

`@korthout` Sorry for assigning you this review but I think some more in-depth knowledge about the topic is useful for this one.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #11660 



Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
ghost pushed a commit that referenced this issue Mar 7, 2023
@remcowesterhoud
merge: #11926
889ba0c 
11926: Add command distribution behavior r=remcowesterhoud a=remcowesterhoud

## Description

<!-- Please explain the changes you made here. -->

This PR introduces the `CommandDistributionBehavior` this behavior is responsible for distributing commands in a generic way.

Note, this code is untested as of now. Since we test engine behavior and not specific behavior implementations it will be tested when we've switched the `DeploymentCreateProcessor` to this new way of distributing.

`@korthout` Sorry for assigning you this review but I think some more in-depth knowledge about the topic is useful for this one.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #11660 



Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
ghost pushed a commit that referenced this issue Mar 7, 2023
@remcowesterhoud
merge: #11926
61e745b 
11926: Add command distribution behavior r=remcowesterhoud a=remcowesterhoud

## Description

<!-- Please explain the changes you made here. -->

This PR introduces the `CommandDistributionBehavior` this behavior is responsible for distributing commands in a generic way.

Note, this code is untested as of now. Since we test engine behavior and not specific behavior implementations it will be tested when we've switched the `DeploymentCreateProcessor` to this new way of distributing.

`@korthout` Sorry for assigning you this review but I think some more in-depth knowledge about the topic is useful for this one.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #11660 



Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@ghost ghost closed this as completed in 0b23935 Mar 8, 2023
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
@megglos megglos mentioned this issue Jul 3, 2023
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remcowesterhoud remcowesterhoud

Labels
component/engine kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add command distribution behavior camunda/camunda
3 participants
@npepinpe @korthout @remcowesterhoud