Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect usage on zbctl evaluate decision --help #12017

Closed
korthout opened this issue Mar 14, 2023 · 1 comment · Fixed by #12030
Closed

Incorrect usage on zbctl evaluate decision --help #12017

korthout opened this issue Mar 14, 2023 · 1 comment · Fixed by #12030
Assignees
Labels
component/clients good first issue Marks an issue as simple enough for first time contributors kind/bug Categorizes an issue or PR as a bug kind/documentation Categorizes an issue or PR as documentation related severity/mid Marks a bug as having a noticeable impact but with a known workaround version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0

Comments

@korthout
Copy link
Member

korthout commented Mar 14, 2023

Describe the bug

The usage of evaluate decision through zbctl refers to processId or processKey but should instead refer to a decision.

$ zbctl.darwin evaluate decision --help
Evaluates a decision defined by the decision ID or decision key

Usage:
  zbctl evaluate decision <processId or processKey> [flags]

Flags:
  -h, --help               help for decision
      --variables string   Specify variables as JSON string (default "{}")

...

To Reproduce

  • execute (in a shell) zbctl.darwin evaluate decision --help
  • notice the usage referring to processId or processKey

Expected behavior

The usage should refer to a decision instead of a process.

@korthout korthout added kind/bug Categorizes an issue or PR as a bug kind/documentation Categorizes an issue or PR as documentation related scope/clients-go severity/mid Marks a bug as having a noticeable impact but with a known workaround component/clients good first issue Marks an issue as simple enough for first time contributors labels Mar 14, 2023
@korthout
Copy link
Member Author

@koevskinikola is already working on this. @berkaycanbc Would be a good opportunity to review this :)

@ghost ghost closed this as completed in bc23942 Mar 17, 2023
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/clients good first issue Marks an issue as simple enough for first time contributors kind/bug Categorizes an issue or PR as a bug kind/documentation Categorizes an issue or PR as documentation related severity/mid Marks a bug as having a noticeable impact but with a known workaround version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants