Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ProtocolFactory to ensure that it uses a fixed seed. #9315

Closed
Tracked by #8609
npepinpe opened this issue May 6, 2022 · 0 comments · Fixed by #9322
Closed
Tracked by #8609

Refactor ProtocolFactory to ensure that it uses a fixed seed. #9315

npepinpe opened this issue May 6, 2022 · 0 comments · Fixed by #9322
Assignees
@npepinpe
Labels
area/maintainability Marks an issue as improving the maintainability of the project area/test Marks an issue as improving or extending the test coverage of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@npepinpe
Copy link
Member

npepinpe commented May 6, 2022 •
edited
Loading

Description

Currently, every ProtocolFactory instance is created, by default, with a new seed. This means every factory produces different records. For development, it's important that our tests are reproducible. To that end, we should ensure all factories use the same seed by default.

For cases where you want different records, we should still be able to pass a seed ourselves.
@npepinpe npepinpe mentioned this issue May 6, 2022
Closed
9 tasks
@npepinpe npepinpe changed the title Refactor <code class="notranslate">ProtocolFactory` to ensure that it uses a fixed seed. Refactor ProtocolFactory to ensure that it uses a fixed seed. May 6, 2022
@npepinpe npepinpe self-assigned this May 6, 2022
@npepinpe npepinpe added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. team/process-automation area/test Marks an issue as improving or extending the test coverage of the project area/maintainability Marks an issue as improving the maintainability of the project labels May 6, 2022
@npepinpe npepinpe mentioned this issue May 6, 2022
Merged
10 tasks
@ghost ghost closed this as completed in e6d9e9a May 10, 2022
@ChrisKujawa ChrisKujawa added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npepinpe npepinpe

Labels
area/maintainability Marks an issue as improving the maintainability of the project area/test Marks an issue as improving or extending the test coverage of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reproducible ProtocolFactory across runs camunda/camunda
3 participants
@npepinpe @ChrisKujawa @remcowesterhoud