Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract index name and record routing logic from ElasticsearchClient #9327

Closed
Tracked by #9320
npepinpe opened this issue May 7, 2022 · 0 comments · Fixed by #9333
Closed
Tracked by #9320

Extract index name and record routing logic from ElasticsearchClient #9327

npepinpe opened this issue May 7, 2022 · 0 comments · Fixed by #9333
Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@npepinpe
Copy link
Member

npepinpe commented May 7, 2022 •
edited
Loading

Description

The index names, the record's document IDs, and the routing logic are all part of a public API which consumers of the exported records rely on. To ensure this is tested properly, we can extract that logic out of the ElasticsearchClient class and into its own SRP class.
@npepinpe npepinpe mentioned this issue May 7, 2022
Closed
6 tasks
@npepinpe npepinpe changed the title <code class="notranslate">IndexRouter`: a poorly named class whose responsibility is to compute the ID of a record, and the index of a record. It also can compute only, say, the prefix of the record. The goal is that it encapsulates the part of the exporter's API that defines index names and record IDs, both of which must be stable for consumers. Extract index name and record routing logic from ElasticsearchClient May 7, 2022
@npepinpe npepinpe added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. team/process-automation area/maintainability Marks an issue as improving the maintainability of the project labels May 7, 2022
@npepinpe npepinpe mentioned this issue May 7, 2022
Merged
10 tasks
@ghost ghost closed this as completed in 66e9d2a May 10, 2022
@ChrisKujawa ChrisKujawa added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extracts record index routing logic from ElasticsearchClient camunda/camunda
3 participants
@npepinpe @ChrisKujawa @remcowesterhoud