Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract index template management from ElasticsearchClient #9328

Closed
Tracked by #9320
npepinpe opened this issue May 7, 2022 · 0 comments · Fixed by #9332
Closed
Tracked by #9320

Extract index template management from ElasticsearchClient #9328

npepinpe opened this issue May 7, 2022 · 0 comments · Fixed by #9332
Assignees
@npepinpe
Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@npepinpe
Copy link
Member

npepinpe commented May 7, 2022 •
edited
Loading

Description

See #9320 for context and motivation. The goal here is to create a new component, TemplateReader, which takes care of reading templates from the resources and configuring them.

This will make unit testing templates (which are part of our public API) much more easily. Although as templates are not tested at the moment, the goal here isn't to increase coverage dramatically - these single tests can be added later.
@npepinpe npepinpe mentioned this issue May 7, 2022
Closed
6 tasks
@npepinpe npepinpe changed the title <code class="notranslate">TemplateReader: reads templates from the <code class="notranslate">resources, optionally substituting some of the properties for configuration properties, e.g. the index prefix, the number of shards, etc. Extract index template management from ElasticsearchClient May 7, 2022
@npepinpe npepinpe self-assigned this May 7, 2022
@npepinpe npepinpe added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. team/process-automation area/maintainability Marks an issue as improving the maintainability of the project labels May 7, 2022
@npepinpe npepinpe mentioned this issue May 7, 2022
Merged
10 tasks
@ghost ghost closed this as completed in e1e11b8 May 10, 2022
@ChrisKujawa ChrisKujawa added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npepinpe npepinpe

Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract template handling from ElasticsearchClient camunda/camunda
3 participants
@npepinpe @ChrisKujawa @remcowesterhoud