Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract RestClient creation logic out of the ElasticsearchClient #9329

Closed
Tracked by #9320
npepinpe opened this issue May 7, 2022 · 0 comments · Fixed by #9341
Closed
Tracked by #9320

Extract RestClient creation logic out of the ElasticsearchClient #9329

npepinpe opened this issue May 7, 2022 · 0 comments · Fixed by #9341
Assignees
@npepinpe
Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@npepinpe
Copy link
Member

npepinpe commented May 7, 2022 •
edited
Loading

Description

The ElasticsearchClient class creates a new RestClient based on user configuration passed via ElasticsearchExporterConfiguration. Splitting this out will allow us to test that the rest clients are properly constructed, and also allow us to reuse the same logic to construct high level REST clients for testing.
@npepinpe npepinpe mentioned this issue May 7, 2022
Closed
6 tasks
@npepinpe npepinpe changed the title <code class="notranslate">RestClientFactory: what the name says, takes in the <code class="notranslate">ElasticsearchExporterConfiguration and produces a <code class="notranslate">RestClient. This was helpful to also reuse the same factory in tests to create an official <code class="notranslate">ElasticsearchClient using the same <code class="notranslate">RestClient` Extract RestClient creation logic out of the ElasticsearchClient May 7, 2022
@npepinpe npepinpe self-assigned this May 7, 2022
@npepinpe npepinpe added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. team/process-automation area/maintainability Marks an issue as improving the maintainability of the project labels May 7, 2022
@npepinpe npepinpe mentioned this issue May 11, 2022
Merged
10 tasks
@ghost ghost closed this as completed in #9341 May 11, 2022
@ghost ghost closed this as completed in 2e598d1 May 11, 2022
@ChrisKujawa ChrisKujawa added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npepinpe npepinpe

Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract RestClient creation logic into a specific factory camunda/camunda
3 participants
@npepinpe @ChrisKujawa @remcowesterhoud