Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ElasticsearchClient after previous parallel refactorings #9340

Closed
Tracked by #9320
npepinpe opened this issue May 9, 2022 · 0 comments · Fixed by #9345
Closed
Tracked by #9320

Clean up ElasticsearchClient after previous parallel refactorings #9340

npepinpe opened this issue May 9, 2022 · 0 comments · Fixed by #9345
Assignees
@npepinpe
Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@npepinpe
Copy link
Member

npepinpe commented May 9, 2022 •
edited
Loading

Description

Clean up ElasticsearchClient class after splitting it up. This includes removing any dead code, lowering visibility of fields where it makes sense, etc.
@npepinpe npepinpe mentioned this issue May 9, 2022
Closed
6 tasks
@npepinpe npepinpe self-assigned this May 9, 2022
@npepinpe npepinpe added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. team/process-automation area/maintainability Marks an issue as improving the maintainability of the project labels May 9, 2022
@npepinpe npepinpe mentioned this issue May 10, 2022
Merged
10 tasks
@npepinpe npepinpe linked a pull request May 10, 2022 that will close this issue
Extract record buffering logic out of ElasticsearchClient #9345
Merged
10 tasks
@ghost ghost closed this as completed in 7aa6553 May 12, 2022
@ChrisKujawa ChrisKujawa added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npepinpe npepinpe

Labels
area/maintainability Marks an issue as improving the maintainability of the project kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract record buffering logic out of ElasticsearchClient camunda/camunda
3 participants
@npepinpe @ChrisKujawa @remcowesterhoud