Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Artifact export on job failure fails due to module directory name usage #9437

Closed
ChrisKujawa opened this issue May 23, 2022 · 2 comments · Fixed by #9444
Closed

GHA: Artifact export on job failure fails due to module directory name usage #9437

ChrisKujawa opened this issue May 23, 2022 · 2 comments · Fixed by #9444
Labels
area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) area/project Marks an issue as related to project management (e.g. PR templates, editor config, etc.) area/test Marks an issue as improving or extending the test coverage of the project kind/bug Categorizes an issue or PR as a bug kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@ChrisKujawa
Copy link
Member

ChrisKujawa commented May 23, 2022

Describe the bug

It seems due to going back to module paths with #9368 we introduce a new failure on exporting the artifacts

Run actions/upload-artifact@v3
  with:
    name: Unit test results for ./atomix/cluster
    path: **/target/surefire-reports/
  **/hs_err_*.log
  
    retention-days: 7
    if-no-files-found: warn
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.[3](https://github.com/camunda/zeebe/runs/6527368042?check_suite_focus=true#step:6:3)-7/x6[4](https://github.com/camunda/zeebe/runs/6527368042?check_suite_focus=true#step:6:4)
With the provided path, there will be [9](https://github.com/camunda/zeebe/runs/6527368042?check_suite_focus=true#step:6:9)3 files uploaded
Starting artifact upload
For more detailed logs during the artifact upload process, enable step-debugging: https://docs.github.com/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging#enabling-step-debug-logging
Error: Artifact name is not valid: Unit test results for ./atomix/cluster. Contains the following character:  Forward slash /
          
Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n, Backslash \, Forward slash /
          
These characters are not allowed in the artifact name due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems.

See https://github.com/camunda/zeebe/runs/6527368042?check_suite_focus=true

To Reproduce

Lets a job fail.

Expected behavior

No issues on exporting artifacts.

@ChrisKujawa ChrisKujawa added kind/bug Categorizes an issue or PR as a bug kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. area/test Marks an issue as improving or extending the test coverage of the project area/project Marks an issue as related to project management (e.g. PR templates, editor config, etc.) area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) labels May 23, 2022
@ChrisKujawa
Copy link
Member Author

It is not 100% clear to me why it fails.

I think the action which fails is this one: https://github.com/camunda/zeebe/blob/main/.github/workflows/test.yml#L117-L124 but it doesn't reference the path we use for executing our tests

@lenaschoenburg
Copy link
Member

but it doesn't reference the path we use for executing our tests

It does, via matrix.project here: https://github.com/camunda/zeebe/blob/main/.github/workflows/test.yml#L121

I think the best option would be to strip the ./ in the project-list step. That way, the overview of tests in GH is also a bit more aesthetically pleasing.

@ghost ghost closed this as completed in e4320a2 May 25, 2022
@ghost ghost closed this as completed in #9444 May 25, 2022
@ChrisKujawa ChrisKujawa added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) area/project Marks an issue as related to project management (e.g. PR templates, editor config, etc.) area/test Marks an issue as improving or extending the test coverage of the project kind/bug Categorizes an issue or PR as a bug kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants