Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release announcement from definition of done #10850

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

korthout
Copy link
Member

@korthout korthout commented Oct 28, 2022

Description

Removes the release announcement task from the Definition of Done that exists in the GitHub pull request template.

The Zeebe team used to be responsible for writing the release blog post. To help remember what is part of which release, the Blog Post folder on Google Drive could be used to update the release announcement. Since the team is no longer responsible for this, we see no value in keeping this document up to date.

Related issues

NA

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

This commit removes the release announcement task from the Definition
of Done that exists in the GitHub pull request template.

The Zeebe team used to be responsible for writing the release blog post.

To help remember what is part of which release, the Blog Post folder
on Google Drive could be used to update the release announcement.

Since the team is no longer responsible for this, we see no value in 
keeping this document up to date.
@korthout korthout marked this pull request as ready for review October 28, 2022 09:06
@korthout korthout requested review from saig0 and npepinpe October 28, 2022 09:06
@github-actions
Copy link
Contributor

Test Results

   949 files  ±    0     949 suites  ±0   1h 43m 19s ⏱️ + 2m 37s
7 602 tests  - 100  7 595 ✔️  - 100  7 💤 ±0  0 ±0 
7 800 runs   - 100  7 791 ✔️  - 100  9 💤 ±0  0 ±0 

Results for commit f8d44d7. ± Comparison against base commit dfae49f.

Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korthout 👍

@saig0 saig0 merged commit 70112c0 into main Oct 28, 2022
@saig0 saig0 deleted the korthout-rm-release-announcement branch October 28, 2022 11:26
@remcowesterhoud remcowesterhoud added the version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 label Dec 6, 2022
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants