Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix medic benchmark workflow #11176

Merged
merged 7 commits into from
Dec 5, 2022
Merged

ci: fix medic benchmark workflow #11176

merged 7 commits into from
Dec 5, 2022

Conversation

lenaschoenburg
Copy link
Member

@lenaschoenburg lenaschoenburg commented Dec 5, 2022 •
edited
Loading

Fixes various small issues in the medic benchmark workflow.

@lenaschoenburg lenaschoenburg requested a review from saig0 December 5, 2022 07:59
@lenaschoenburg
ci: fix medic benchmark workflow
c9351a3 
benchmark-data comes from a different job, not a different step.
@saig0
Copy link
Member

saig0 commented Dec 5, 2022 •
edited
Loading

@oleschoenburg the previous issue is fixed. 👍

Now, there is an issue when deleting old benchmarks: https://github.com/camunda/zeebe/actions/runs/3618091736/jobs/6097549980

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022 •
edited
Loading

Test Results

   971 files  ±  0     971 suites  ±0   1h 51m 15s ⏱️ + 1m 39s
7 716 tests  - 22  7 709 ✔️  - 22  7 💤 ±0  0 ❌ ±0 
7 922 runs   - 22  7 913 ✔️  - 22  9 💤 ±0  0 ❌ ±0 

Results for commit 79bcae7. ± Comparison against base commit 8e0e21b.

♻️ This comment has been updated with latest results.

@lenaschoenburg lenaschoenburg requested a review from saig0 December 5, 2022 08:24
@saig0
Copy link
Member

saig0 commented Dec 5, 2022 •
edited
Loading

@oleschoenburg nice. 👍

It seems there is one more issue with extracting the calendar week: https://github.com/camunda/zeebe/actions/runs/3618091736/jobs/6097549806

The benchmarks were created with an empty CW. See https://github.com/camunda/zeebe/actions/runs/3618091736/jobs/6097553320#step:1:40

@lenaschoenburg lenaschoenburg requested a review from saig0 December 5, 2022 08:54
saig0
saig0 requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleschoenburg nice improvements. 🚀

We are close. But I found one more issue. Please have a look at my comment.

@saig0
Copy link
Member

saig0 commented Dec 5, 2022 •
edited
Loading

@oleschoenburg the last commit fixed the issue. 👍

But now, the step "Deploy benchmark cluster" failed: https://github.com/camunda/zeebe/actions/runs/3618738541/jobs/6099935870. 🙈

@lenaschoenburg lenaschoenburg requested a review from saig0 December 5, 2022 11:06
@lenaschoenburg
Copy link
Member Author

That were a lot of small issues, sorry about that! I think it's working now: https://github.com/camunda/zeebe/actions/runs/3619314666

saig0
saig0 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleschoenburg awesome. 🥳

It works like a charm. 🤩

@saig0 saig0 merged commit 3c4c3a5 into main Dec 5, 2022
@saig0 saig0 deleted the os-fix-medic-benchmark branch December 5, 2022 12:25
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
version:8.2.0-alpha3 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lenaschoenburg @saig0 @npepinpe @ChrisKujawa